Fix PATCH on @user properties if the portrait is empty, returns 400 #752
Conversation
|
@sneridagh thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating: With this simple comment all the jobs will be started automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
buchi
force-pushed
the
fixuserportraitisempty
branch
from
2f7c81a
to
f5f97d5
Compare
|
@sneridagh I've tested this on Plone 5.2, 5.1 and 4.3 and for me it seems to work. A user portrait can be deleted by providing To keep the current portrait, omit |
|
@buchi @sneridagh this kind of raises the general question of how we set null values in plone.restapi. I guess we have to check how we do this on other endpoints and then document that properly for the future. |
…752) * Fix deleting user portrait * Fix image type in user portrait tests Co-authored-by: Thomas Buchberger <t.buchberger@4teamwork.ch>
* master: (133 commits) Fix coveralls (#910) Refs #905 - Fix sphinxbuilder with Python 3.8 (#906) Remove #900 changelog. Released with 6.6.0. Back to development: 6.6.1 Preparing release 6.6.0 Add next and previous feature (#901) Add next and previous feature (#901) Force p.restapi checkout for Plone 5.2 Add performance tests for Plone 5.2.1. Make sure we use the latest p.restapi in performance tests. Remove unused plonesite recipe params. #896/897 has been released with p.restapi 6.5.1/6.5.2. Back to development: 6.5.3 Preparing release 6.5.2 Fix for the use case while updating user properties in the @user endpoint, and the portrait is already previously set but the request includes the (previously) serialized value as a string because the user are not updating it (#897) Fix for the use case while updating user properties in the @user endpoint, and the portrait is already previously set but the request includes the (previously) serialized value as a string because the user are not updating it (#897) Remove news/751.bugfix since it already has been released with 6.5.1. Back to development: 6.5.2 Preparing release 6.5.1 Fix PATCH on @user properties if the portrait is empty, returns 400 (#752) Fix PATCH on @user properties if the portrait is empty, returns 400 (#752) ...
No description provided.