Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #905 - Fix sphinxbuilder with Python 3.8 #906

Merged
merged 2 commits into from
Apr 12, 2020

Conversation

avoinea
Copy link
Member

@avoinea avoinea commented Apr 9, 2020

See #905

@mister-roboto
Copy link

@avoinea thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@avoinea avoinea requested a review from tisto April 9, 2020 15:08
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.571% when pulling e132fd3 on eea:eea-sphinxbuilder into 864d566 on plone:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.571% when pulling e132fd3 on eea:eea-sphinxbuilder into 864d566 on plone:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.571% when pulling e132fd3 on eea:eea-sphinxbuilder into 864d566 on plone:master.

Copy link
Member

@tisto tisto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @avoinea. Just an FYI: we usually do not add changelog entries for internal changes such as buildout fixes or test fixes. Though, I admit that the changelog check on Travis does not make this particularly easy to spot. :/

@tisto tisto merged commit 3e328d8 into plone:master Apr 12, 2020
sneridagh added a commit that referenced this pull request Apr 17, 2020
* master: (133 commits)
  Fix coveralls (#910)
  Refs #905 - Fix sphinxbuilder with Python 3.8 (#906)
  Remove #900 changelog. Released with 6.6.0.
  Back to development: 6.6.1
  Preparing release 6.6.0
  Add next and previous feature (#901)
  Add next and previous feature (#901)
  Force p.restapi checkout for Plone 5.2
  Add performance tests for Plone 5.2.1.
  Make sure we use the latest p.restapi in performance tests. Remove unused plonesite recipe params.
  #896/897 has been released with p.restapi 6.5.1/6.5.2.
  Back to development: 6.5.3
  Preparing release 6.5.2
  Fix for the use case while updating user properties in the @user endpoint, and the portrait is already previously set but the request includes the (previously) serialized value as a string because the user are not updating it (#897)
  Fix for the use case while updating user properties in the @user endpoint, and the portrait is already previously set but the request includes the (previously) serialized value as a string because the user are not updating it (#897)
  Remove news/751.bugfix since it already has been released with 6.5.1.
  Back to development: 6.5.2
  Preparing release 6.5.1
  Fix PATCH on @user properties if the portrait is empty, returns 400 (#752)
  Fix PATCH on @user properties if the portrait is empty, returns 400 (#752)
  ...
tisto pushed a commit that referenced this pull request Apr 21, 2020
* Refs #905 - Fix sphinxbuilder with Python 3.8

* CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants