-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Volto Controlpanel: Dexterity Content Types #1370
Conversation
Volto Controlpanel: Dexterity Content Types
@avoinea pls run prettier to fix Travis/GH Actions. |
@avoinea you have to run "yarn i18n" to fix the CI builds, the translations are outdated. |
@avoinea I tried to change the name of the Folder content type TTW. It seems the select fields are not properly filled: |
@tisto Fixed! |
@avoinea thanks! It works like a charm now. I asked @iFlameing to write a few Cypress tests for the new control panels. Do you know why "filter contained types" has the value "no value"? As a user, it would confuse me to have both "no value" and "none" at the same time. Maybe we should add some explanation for those values to the field descriptions: |
@tisto It looks like is added by Volto to all SelectWidgets: volto/src/components/manage/Widgets/SelectWidget.jsx Lines 344 to 347 in 8b711f8
|
@avoinea I talked to @sneridagh briefly about this. It seems this is one of the things that are necessary for us to fix the underlying Plone backend for Volto. :/ I'd say good to merge then! It would be cool if @sneridagh @robgietema @pnicolli @cekk et al could have a second look at it. |
LGTM 👍 |
Can we merge this? |
@avoinea do you plan to work on Dexterity Types schema editing as well or is this beyond the scope of your work? |
@tisto Yes. But I'd prefer to do it in another PR. |
@avoinea sure. That makes a lot of sense. Let's wait for @sneridagh to push the merge button and release... |
* master: Back to development Release 5.8.0 Prepare for release Adding image template for Listing (#1429) Back to development Release 5.7.1 Prepare for release Fix translation locator lookup in `CreateTranslation` component and remove the no longer needed store reducer (#1468) Back to development Release 5.7.0 Prepare for release Enable `@querystringresults` action to use the new context aware query feature (#1465) Back to development Release 5.6.1 Prepare for release REALLY load the current object language on SSR T_T (#1464) Pin some api deps (#1455)
* master: (24 commits) Fixing blockquote empty line issue (#1456) Volto Controlpanel: Dexterity Content Types (#1370) Back to development Release 5.8.0 Prepare for release Adding image template for Listing (#1429) Back to development Release 5.7.1 Prepare for release Fix translation locator lookup in `CreateTranslation` component and remove the no longer needed store reducer (#1468) Back to development Release 5.7.0 Prepare for release Enable `@querystringresults` action to use the new context aware query feature (#1465) Back to development Release 5.6.1 Prepare for release REALLY load the current object language on SSR T_T (#1464) Pin some api deps (#1455) Back to development ...
* master: (21 commits) Exposing system information in Volto control panel (#1469) Adding cypress test dexterity-controlpanel (#1451) Fixing blockquote empty line issue (#1456) Volto Controlpanel: Dexterity Content Types (#1370) Back to development Release 5.8.0 Prepare for release Adding image template for Listing (#1429) Back to development Release 5.7.1 Prepare for release Fix translation locator lookup in `CreateTranslation` component and remove the no longer needed store reducer (#1468) Back to development Release 5.7.0 Prepare for release Enable `@querystringresults` action to use the new context aware query feature (#1465) Back to development Release 5.6.1 Prepare for release REALLY load the current object language on SSR T_T (#1464) ...
See #1285
Implementation based on plone/plone.restapi#907