Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volto Controlpanel: Dexterity Content Types #1370

Merged
merged 44 commits into from
May 12, 2020
Merged

Conversation

avoinea
Copy link
Member

@avoinea avoinea commented Apr 13, 2020

See #1285

Implementation based on plone/plone.restapi#907

@tisto
Copy link
Member

tisto commented Apr 14, 2020

@avoinea pls run prettier to fix Travis/GH Actions.

@avoinea avoinea linked an issue Apr 14, 2020 that may be closed by this pull request
@avoinea avoinea self-assigned this Apr 23, 2020
@tisto tisto requested a review from sneridagh April 23, 2020 09:56
@tisto
Copy link
Member

tisto commented Apr 30, 2020

@avoinea you have to run "yarn i18n" to fix the CI builds, the translations are outdated.

@tisto
Copy link
Member

tisto commented Apr 30, 2020

@avoinea I tried to change the name of the Folder content type TTW. It seems the select fields are not properly filled:

Folder (1)

@avoinea
Copy link
Member Author

avoinea commented May 4, 2020

@tisto Fixed!

@tisto
Copy link
Member

tisto commented May 4, 2020

@avoinea thanks! It works like a charm now. I asked @iFlameing to write a few Cypress tests for the new control panels.

Do you know why "filter contained types" has the value "no value"? As a user, it would confuse me to have both "no value" and "none" at the same time. Maybe we should add some explanation for those values to the field descriptions:

Screenshot 2020-05-04 at 16 23 17

@avoinea
Copy link
Member Author

avoinea commented May 4, 2020

Do you know why "filter contained types" has the value "no value"?

@tisto It looks like is added by Volto to all SelectWidgets:

{
label: this.props.intl.formatMessage(messages.no_value),
value: 'no-value',
},

@tisto
Copy link
Member

tisto commented May 4, 2020

@avoinea I talked to @sneridagh briefly about this. It seems this is one of the things that are necessary for us to fix the underlying Plone backend for Volto. :/

I'd say good to merge then! It would be cool if @sneridagh @robgietema @pnicolli @cekk et al could have a second look at it.

@cekk
Copy link
Member

cekk commented May 5, 2020

LGTM 👍

@avoinea
Copy link
Member Author

avoinea commented May 8, 2020

Can we merge this?

@tisto
Copy link
Member

tisto commented May 8, 2020

@avoinea do you plan to work on Dexterity Types schema editing as well or is this beyond the scope of your work?

@avoinea
Copy link
Member Author

avoinea commented May 8, 2020

@tisto Yes. But I'd prefer to do it in another PR.

@tisto
Copy link
Member

tisto commented May 8, 2020

@avoinea sure. That makes a lot of sense. Let's wait for @sneridagh to push the merge button and release...

* master:
  Back to development
  Release 5.8.0
  Prepare for release
  Adding image template for Listing (#1429)
  Back to development
  Release 5.7.1
  Prepare for release
  Fix translation locator lookup in `CreateTranslation` component and remove the no longer needed store reducer (#1468)
  Back to development
  Release 5.7.0
  Prepare for release
  Enable `@querystringresults` action to use the new context aware query feature (#1465)
  Back to development
  Release 5.6.1
  Prepare for release
  REALLY load the current object language on SSR T_T (#1464)
  Pin some api deps (#1455)
@sneridagh sneridagh merged commit 4148085 into master May 12, 2020
@sneridagh sneridagh deleted the eea-controlpanel-dx branch May 12, 2020 07:11
sneridagh added a commit that referenced this pull request May 12, 2020
* master: (24 commits)
  Fixing blockquote empty line issue (#1456)
  Volto Controlpanel: Dexterity Content Types (#1370)
  Back to development
  Release 5.8.0
  Prepare for release
  Adding image template for Listing (#1429)
  Back to development
  Release 5.7.1
  Prepare for release
  Fix translation locator lookup in `CreateTranslation` component and remove the no longer needed store reducer (#1468)
  Back to development
  Release 5.7.0
  Prepare for release
  Enable `@querystringresults` action to use the new context aware query feature (#1465)
  Back to development
  Release 5.6.1
  Prepare for release
  REALLY load the current object language on SSR T_T (#1464)
  Pin some api deps (#1455)
  Back to development
  ...
sneridagh added a commit that referenced this pull request May 12, 2020
* master:
  Fixing blockquote empty line issue (#1456)
  Volto Controlpanel: Dexterity Content Types (#1370)
sneridagh added a commit that referenced this pull request May 12, 2020
* master: (21 commits)
  Exposing system information in Volto control panel (#1469)
  Adding cypress test dexterity-controlpanel (#1451)
  Fixing blockquote empty line issue (#1456)
  Volto Controlpanel: Dexterity Content Types (#1370)
  Back to development
  Release 5.8.0
  Prepare for release
  Adding image template for Listing (#1429)
  Back to development
  Release 5.7.1
  Prepare for release
  Fix translation locator lookup in `CreateTranslation` component and remove the no longer needed store reducer (#1468)
  Back to development
  Release 5.7.0
  Prepare for release
  Enable `@querystringresults` action to use the new context aware query feature (#1465)
  Back to development
  Release 5.6.1
  Prepare for release
  REALLY load the current object language on SSR T_T (#1464)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control Panel: Dexterity content types
5 participants