Fix search block showing no option select in sort on property (#5055) (Backport 17.x.x) #6221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davisagli
approved these changes
Aug 1, 2024
@davisagli yup you're welcomed, I was asking you if you wanted to backport also to 17 and then Victor said let's do it so I figured I would do my 10 min help part as well :) I noticed that you've removed the extra translation, I guess we should clean up the message definition in the main branch since it's not used. |
|
@ichim-david Yeah -- I noticed the translation was unused after I merged the PR to main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.