Allow any version of Dash #388
Conversation
|
@chriddyp We have been holding off on doing this since the tests weren't passing: #367 (comment) I'll try running the tests locally with |
|
Could we lock the version for the tests (i.e. |
|
Yes, that will work. I can take over the PR if you want! |
|
All yours, thanks @shammamah ! |
This doesn't work and we've known it for weeks, if not months. We've been waiting for the testing framework refactoring. I can link to the discussions where we report and detail all that for the n-th time, if needed. |
|
My main point is let’s not let our own testing refactoring prevent fixing this for our end users. |
|
@mkcor My mistake -- I thought the refactoring was completed in |
Great, I'm all for it! If anything, I'm noticing that this decision could/should have been made earlier (we were blocked and that's not good, I just meant to remind that we knew we were blocked and why: #367 (comment)). @shammamah don't forget to update the CircleCI config as well! |
tests/requirements.txt
Outdated
|
|
||
| # Additional packages needed to run the tests. | ||
| chromedriver-binary==2.45.0 | ||
| dash==0.40.0 |
There was a problem hiding this comment.
This will create a double (at the moment, redundant) requirement, because of -r ../requirements.txt (top of the file). I suggest replacing the latter with all requirements except for dash.
There was a problem hiding this comment.
Alternatively, revert d3993ea because it's already ensured through (top-level) requirements.txt). This way we have a clear and healthy use of setup.py vs requirements.txt files.
There was a problem hiding this comment.
Done in 2dd952e -- can't wait to unblock the situation...
This reverts commit d3993ea.
|
@shammamah or @chriddyp please merge asap to resolve https://github.com/plotly/dash-docs/issues/598 and let Dash Bio's development follow smoothly that of the Dash ecosystem. Next up, we want to migrate to React 16! |
Closes https://github.com/plotly/dash-docs/issues/598
About
Description of changes
Right now, Dash Bio is incompatible with newer versions of Dash including that which we use in documentation. Ideally, component libraries have a loose dependency on Dash - the user should be able to upgrade and install Dash independently of the component package, and the component package shouldn't have to create a new release with every release of Dash.
Before merging