Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

fixed max date range issue #58

Merged
merged 8 commits into from
Aug 18, 2017
Merged

fixed max date range issue #58

merged 8 commits into from
Aug 18, 2017

Conversation

alishobeiri
Copy link
Contributor

No description provided.

@@ -32,6 +32,7 @@
"ramda": "^0.23.0",
"rc-slider": "^6.1.0",
"react": "^15.4.0",
"react-addons-shallow-compare": "^15.6.0",
Copy link
Member

@chriddyp chriddyp Aug 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it's an addon required for react-dates package

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the line isn't there if somebody cloned the repo, they would run into an error when they try to npm i

@chriddyp
Copy link
Member

looks good @alishobeiri - could you update the versions and the changelog? then i'll merge and make a new release. see http://keepachangelog.com/ and http://semver.org/ for more info on changelog format and semver.

@alishobeiri
Copy link
Contributor Author

alishobeiri commented Aug 17, 2017

@chriddyp Should be good now I think, let me know what you think

CHANGELOG.md Outdated
@@ -2,6 +2,10 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [0.12.2] - 2017-08-17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be 0.12.3

@chriddyp chriddyp merged commit 588c24a into master Aug 18, 2017
@chriddyp chriddyp deleted the date-picker-max-date-bug branch August 18, 2017 19:09
chriddyp pushed a commit that referenced this pull request Aug 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants