Add showScalarBar and scalarBarTitle in GeometryRepresentation #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigomologni
requested review from
jourdain,
alexcjohnson and
xhluca
as code owners
|
@rodrigomologni I would really appreciate it if you could you also expose these properties in PointCloudRepresentation. It uses the same ones as GeometryRepresentation. |
|
@solarjoe done! |
|
Can you rebase on master? I'm wondering if the CI was fixed on master... |
* add showCubeAxes * add showScalarBar * add scalarBarTitle
rodrigomologni
force-pushed
the
fix/show-scalar-bar
branch
from
e750262 to
ac98222
Compare
|
@jourdain done! |
|
I guess the next step is to follow the publish steps |
|
It seems that this issue has been fixed for a long time, but the version on pypi is still the old version. Is there any plan to release a new version? Because this is very important in multiple fields such as temperature change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR enables the use of
showScalarBarandscalarBarTitleinGeometryRepresentation:Pre-Merge checklist
npm run build.