Move the renderer build into the renderer dir #1685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needed for npm publishing to get all the right files
|
The test failure is very strange... |
eff-kay
reviewed
Jul 9, 2021
eff-kay
reviewed
Jul 9, 2021
eff-kay
reviewed
Jul 9, 2021
|
some tests fail, but other than that LGTM. |
|
It looks like webpack 5 indeed removes the script after it executes. AFAICT this was silently introduced with another feature and never documented. I'm just going to tweak the test to ensure the graph rendered and the sync module is present iff expected. |
alexcjohnson
force-pushed
the
move-renderer-build
branch
from
f424c8b to
9810d96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @HammadTheOne - since the renderer is also an npm package, we want to keep its build output within that package for npm publishing to get all the right files. But I left all the other js deps in the deps folder where you put them in #1611.
@eff-kay please review - this is I think the last change we need before we can publish a new version of Dash.
Contributor Checklist
optionals
CHANGELOG.md