Change _validate_layout to accept functions that return layouts. #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T4rk1n
reviewed
Aug 15, 2018
| layout_id = getattr(self.layout, 'id', None) | ||
|
|
||
| component_ids = {layout_id} if layout_id else set() | ||
| for component in self.layout.traverse(): | ||
| for component in to_validate.traverse(): |
There was a problem hiding this comment.
Why not use self._layout_value() ? it basically does the same check.
tests/test_integration.py
Outdated
| @@ -12,7 +12,7 @@ | |||
| import time | |||
|
|
|||
| from dash.dependencies import Input, Output | |||
| from dash.exceptions import PreventUpdate | |||
| from dash.exceptions import PreventUpdate, NoLayoutException | |||
There was a problem hiding this comment.
I don't see NoLayoutException used anywhere.
|
Fixed those, I'll rebase and see if the new CI passes |
|
Would this PR fix https://community.plot.ly/t/attribute-error-layout-traverse/13031? |
|
^ Yes it should. Can someone check out whats up with Percy, those tests worked out before bumping changelog and version |
|
Okay, it looks like plotly/dash-core-components#280 and the release of Can someone check to make sure those are okay? I do not currently have permissions to view |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #334