Skip to content

require htmlwidgets 1.3 or higher so async shiny "just works", closes #1297 #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2018
Merged

require htmlwidgets 1.3 or higher so async shiny "just works", closes #1297 #1335

merged 2 commits into from
Oct 4, 2018

Conversation

cpsievert
Copy link
Collaborator

@cpsievert cpsievert commented Sep 17, 2018 •
edited
Loading

No description provided.

@cpsievert cpsievert requested a review from jcheng5 October 4, 2018 14:53
@cpsievert cpsievert changed the title warn if a promise is passed to renderPlotly(), but htmlwidgets is out-of-date, closes #1297 require htmlwidgets 1.3 or higher so async shiny "just works", closes #1297 Oct 4, 2018
@cpsievert cpsievert merged commit f43699e into master Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jcheng5 jcheng5 jcheng5 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpsievert @jcheng5