Skip to content

Fix badly chosen default positioning for sliders #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2016
Merged

Fix badly chosen default positioning for sliders #1029

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bce9eae
Fix a badly set default x value for sliders
rreusser Oct 11, 2016
2695591
Fix more slider positioning defaults
rreusser Oct 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/components/sliders/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
var fontAttrs = require('../../plots/font_attributes');
var padAttrs = require('../../plots/pad_attributes');
var extendFlat = require('../../lib/extend').extendFlat;
var extendDeep = require('../../lib/extend').extendDeep;
var animationAttrs = require('../../plots/animation_attributes');
var constants = require('./constants');

Expand Down Expand Up @@ -105,13 +106,13 @@ module.exports = {
valType: 'number',
min: -2,
max: 3,
dflt: -0.05,
dflt: 0,
role: 'style',
description: 'Sets the x position (in normalized coordinates) of the slider.'
},
pad: extendFlat({}, padAttrs, {
pad: extendDeep({}, padAttrs, {
description: 'Set the padding of the slider component along each side.'
}),
}, {t: {dflt: 20}}),
xanchor: {
valType: 'enumerated',
values: ['auto', 'left', 'center', 'right'],
Expand All @@ -127,14 +128,14 @@ module.exports = {
valType: 'number',
min: -2,
max: 3,
dflt: 1,
dflt: 0,
role: 'style',
description: 'Sets the y position (in normalized coordinates) of the slider.'
},
yanchor: {
valType: 'enumerated',
values: ['auto', 'top', 'middle', 'bottom'],
dflt: 'bottom',
dflt: 'top',
role: 'info',
description: [
'Sets the slider\'s vertical position anchor',
Expand Down