Skip to content

Conversation

monfera
Copy link
Contributor

@monfera monfera commented Nov 15, 2016

Testing with fix in gl-vis. Fixes #1145

@etpinard
Copy link
Contributor

tested ✅

Thanks very much!

@etpinard etpinard added status: reviewable bug something broken labels Nov 15, 2016
@etpinard etpinard added this to the v1.20.0 milestone Nov 15, 2016
@etpinard
Copy link
Contributor

@monfera maybe we could make gl2d_click_test.js test the regression (if not too hard)?


});

it('scattergl', function(done) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

@monfera monfera force-pushed the 1145-scatter-hover-bug branch from e72ae46 to eeed987 Compare November 15, 2016 19:38
@monfera monfera changed the title [WIP] Fixing the pickOffset bug in non-fancy gl-scatter2d Fixing the pickOffset bug in non-fancy gl-scatter2d Nov 15, 2016
@etpinard etpinard merged commit 7c9b538 into plotly:master Nov 15, 2016
@monfera monfera mentioned this pull request Nov 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scattergl hover bug
2 participants