add fallback in autobin routine #1284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- so that trying to plot a histogram with categorical sample pts on a linear axis result in blank plot instead of `ax.dtick` exception.
|
This bug was discovered while debugging for #1231 but does not resolve #1231 @alexcjohnson looks ok? |
alexcjohnson
reviewed
Jan 6, 2017
| // fallback if ax.d2c output BADNUMs | ||
| // e.g. when user try to plot categorical bins | ||
| // on a layout.xaxis.type: 'linear' | ||
| if(!isNumeric(size0)) size0 = 0; |
There was a problem hiding this comment.
If a bin size of 0 made it through, this could lead to infinite loops or divide-by-zero errors somewhere else. It looks like Axes.autoTicks has its own fallback for this so dummyAx.dtick won't be zero, which is why this works for now, but perhaps it would be better to use size0 = 1 instead so we don't have to depend on this behavior from autoTicks?
- for better protection from infinity loops in Axes.autoTicks
etpinard
commented
Jan 9, 2017
| }); | ||
| }); | ||
|
|
||
| it('should not error out for categories on linear axis', function() { |
There was a problem hiding this comment.
This case and the two below resulted in errors previously.
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that trying to plot a histogram with categorical sample pts on a linear axis result in blank plot instead of
ax.dtickexception.For example,
currently lead to:
with this patch, the above snippet generates a blank graph.