Annotations drag fix #1441
Merged
Annotations drag fix #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcjohnson
commented
Mar 3, 2017
|
|
||
| function waitForDragCover() { | ||
| return new Promise(function(resolve) { | ||
| var interval = 5, |
There was a problem hiding this comment.
Previously this was DBLCLICKDELAY/4 which is 75 msec, and it was cumulatively responsible for almost 20 extra seconds of delay in shapes_test. Runs fine at 5 msec.
etpinard
reviewed
Mar 3, 2017
| .then(done); | ||
| }); | ||
|
|
||
| it('works data-referenced with arrow', function(done) { |
|
💃 looks good! 2 patched lines in I hope you won't have to bump the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes annotation dragging, which was broken back in #1265 - and tests it in all permutations of data/paper reference and arrow/no arrow
@etpinard please review - will need a patch release for this to get 1.24 into the workspace.