Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edits for no unwarranted colorscale or related data on parcoords trace/fullTrace #1509

Merged
merged 1 commit into from Mar 22, 2017
Merged

Edits for no unwarranted colorscale or related data on parcoords trace/fullTrace #1509

merged 1 commit into from Mar 22, 2017

Conversation

etpinard
Copy link
Contributor

to be merged into #1508

cc @monfera

@etpinard
move back color computations in calc
f150b9b 
- but store results in calcdata items, instead of mutating
  the corresponding fullData items.
monfera
monfera approved these changes Mar 22, 2017
View reviewed changes
Copy link
Contributor

@monfera monfera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks again!!! CI initially failed on an issue I saw yesterday so I restarted it.

@etpinard etpinard merged commit 8b4124a into parcoords-avoid-colorscale Mar 22, 2017
@etpinard etpinard deleted the parcoords-avoid-colorscale-etienne branch March 22, 2017 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monfera monfera monfera approved these changes

Assignees
No one assigned
Labels
status: reviewable type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etpinard @monfera