Skip to content

Cast to empty array #1567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 7, 2017
Merged

Cast to empty array #1567

merged 3 commits into from
Apr 7, 2017

Conversation

dy
Copy link
Contributor

@dy dy commented Apr 7, 2017

Tiny fix for #1139
No idea why it was done for x but was not for y.

@etpinard
Copy link
Contributor

etpinard commented Apr 7, 2017

nice find 🔬

@dy dy mentioned this pull request Apr 7, 2017
Closed
@etpinard
Copy link
Contributor

etpinard commented Apr 7, 2017

@dfcreative wanna try adding a jasmine test for this in gl_plot_interact_test.js? This particular test should is a good example of I'm expecting.

@etpinard etpinard added status: in progress bug something broken labels Apr 7, 2017
@dy
Copy link
Contributor Author

dy commented Apr 7, 2017

@etpinard appended test targeting specifically this case

@etpinard etpinard added this to the v1.26.0 milestone Apr 7, 2017
@etpinard etpinard merged commit f6f2048 into plotly:master Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
v1.26.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dy @etpinard