Skip BADNUM items in scatter select routine #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- unfinished business from b5cd573
- so that BADNUM items are not included in the 'plotly_selected' event data.
alexcjohnson
reviewed
May 8, 2017
src/traces/scatter/select.js
Outdated
|
|
||
| if(x === BADNUM || y === BADNUM) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
I take it from this fix that polygon.contains fails for undefined inputs? I would think for future extensibility it would be better to fix it in there, so if either x or y is BADNUM it's not contained in any polygon.
There was a problem hiding this comment.
Good call. Done in 80cee01
- also make sure that 'lasso' dragmode is tested
|
馃拑 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1648
This PR first replaces
{ x: false, y: false }scatter calcdata items with{ x: BADNUM, y: BADNUM }as put forward in b5cd573 then makes sure to skip those BADNUM items (as opposed to casting them to numbers - see codepen in #1648) in the scatter select routine.cc @alexcjohnson it would be nice to include this in
1.27.0if you get the time to review it 馃槃