Add execute flag to components
#1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If not a spy, do you want to just check that |
rreusser
force-pushed
the
add-execute-flag-to-components
branch
from
90da8ac
to
29fcace
Compare
|
Looks great, thanks for the test! 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the second part of #1695 by adding an
executeflag to sliders and updatemenus API calls. I had a bit of trouble getting a spy to work, so I omitted the end to end test at the moment. The full extent of the change is to simply sidestep the call toPlots.executeAPICommand, so it should have few effects except to skip the API call.I have not yet tested whether everything works identically if the API call is moved into the event handler. Although that's the reason for this PR to exist, it's also a separate usage concern.
/cc @etpinard @alexcjohnson
#1695