Sankey rotation between horizontal and vertical #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s that do not properly support CSS styles
|
Personally the part of this PR I'm most excited about is that the node/link alignment is cleaner now in vertical orientation (as shown in the baseline image change) 🎉 The transition is good too 😉 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an IE shortcoming a fix was necessary that further deteriorated an already dubious transition between horizontal and vertical Sankey.
This PR has a profound impact on what happens when running the
sankey_energy.jsonmock and switching it from horizontal to vertical and back. As a side effect, while the source code is a tad longer, a lot of lines became shorter and simpler as the new logic has fewer conditionalization on the orientation.