clear calcdata before redoing it in animations #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
reviewed
May 26, 2017
| @@ -1813,6 +1813,10 @@ plots.transition = function(gd, data, layout, traces, frameOpts, transitionOpts) | |||
| // of essentially the whole supplyDefaults step, so that it seems sensible to just use | |||
| // supplyDefaults even though it's heavier than would otherwise be desired for | |||
| // transitions: | |||
|
|
|||
| // first delete calcdata so supplyDefaults knows a calc step is coming | |||
| delete gd.calcdata; | |||
There was a problem hiding this comment.
Looks like a solid fix. It will slow down Plotly.animate though.
There was a problem hiding this comment.
There's some logic in Plots.doCalcdata involving old versus new calcdata that might be obsolete now.
There was a problem hiding this comment.
will it? We're calling doCalcdata no matter what so I'd think this will actually speed it up a tiny bit!
|
Here's at least a codepen that isolates this effect (plotly-latest works though so it's not visible in the codepen) https://codepen.io/rsreusser/pen/rmbrXg?editors=0010 Correction: not the wrong frame; just the failure to transition. |
|
Great thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue we're seeing with calcTransforms + animations, which was introduced in #1717
Then the question is: what do we test this with and how?
cc @etpinard @rreusser