Validate dynamic enumerated #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- so that attribute that declare possible values as regex e.g. axis anchor and overlaying pass `Lib.validate()`
- e.g. axis 'anchor' declare both x and y values, but coerce x or y values depending on the container. - similarly for 'overlaying' and 'contraintoward'
etpinard
commented
Jun 8, 2017
| @@ -44,6 +44,20 @@ exports.valObjects = { | |||
| if(opts.coerceNumber) v = +v; | |||
| if(opts.values.indexOf(v) === -1) propOut.set(dflt); | |||
| else propOut.set(v); | |||
| }, | |||
| validateFunction: function(v, opts) { | |||
There was a problem hiding this comment.
This thing in only called during Lib.validate. We need this so that make enumerated attributes like xaxis.anchor that declare regex work with Lib.validate.
There was a problem hiding this comment.
oh and I should add, I didn't want to add regex support in the (regular) coerceFunction defined above for performance reasons.
|
Looks great! 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be merged in @alexcjohnson 's #1767
fixes
Plotly.validatefor axisanchor,overlayingandcontraintoward.