Mapbox reset view back to initial #1883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- resets view back to initial values - keep track of those initial values on instantiation - add *toggleHover* button too (that just works)
- which reset view back to initial values
- too slow on CircleCI machines
etpinard
changed the title
|
nice and clean. 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... via a new mode bar button and double click.
Moreover, this PR adds the generic
toggleHovermode bar button to mapbox subplots.This helps mabpox subplots become more on-par with our other older subplot types (see more in #815). I hope you'll ❤️ the changes.