Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix heatmapgl point number event data #1884

Merged
merged 2 commits into from Jul 17, 2017
Merged

Fix heatmapgl point number event data #1884

merged 2 commits into from Jul 17, 2017

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented Jul 14, 2017

fixes #1825

Luckily, the problem described in #1825 only concerns heatmapgl - as opposed to the solution proposed in #1833.

The patch is simple. It brings heatmapgl's pointNumber event data field on par with other 2D trace types. This PR also adds an asymmetric heatmapgl hover test case.

cc @alexcjohnson @dfcreative

- so that z[ny][nx]
  where ny = pointNumber[1] and nx = pointNumber[0]
@@ -77,7 +77,7 @@ proto.handlePick = function(pickResult) {
],
textLabel: this.textLabels[index],
name: this.name,
pointIndex: [xIndex, yIndex],
pointIndex: [yIndex, xIndex],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @dfcreative for that #1825 (comment)

@alexcjohnson
Copy link
Contributor

Works for me! 💃

@etpinard etpinard merged commit 9948af4 into master Jul 17, 2017
@etpinard etpinard deleted the heatmapgl-hover-fix branch July 17, 2017 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

heatmapgl cursor popup can't go wider than the plot is tall
2 participants