safer construction of popup click handler #1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
reviewed
Jul 17, 2017
| @@ -459,7 +461,7 @@ function buildSVGText(containerNode, str) { | |||
| var dummyAnchor = document.createElement('a'); | |||
| dummyAnchor.href = href; | |||
| if(PROTOCOLS.indexOf(dummyAnchor.protocol) !== -1) { | |||
| nodeSpec.href = href; | |||
| nodeSpec.href = encodeURI(href); | |||
There was a problem hiding this comment.
FWIW I couldn't identify any vulnerability due to not calling encodeURI here - quotes and other special characters embedded in href still can't break you out of the href attribute (while constructing the onclick string or otherwise) to where you can cause more damage - but it makes strange items look more url-like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an XSS vulnerability in links defined with the special
popupattribute. See the added test case for three variants that were previously able to exploit it.The fix here constructs the
onclickhandler in a safer way: it re-extractshrefandtargetfrom the element attributes, and it restricts the characters allowed in thepopup(strWindowFeatures) attribute since we know there's only so much that can be used there.cc @etpinard @scjody - this bug came in with #1783 which was included in v1.28.0