Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump has-hover #1890

Merged
merged 1 commit into from Jul 19, 2017
Merged

Bump has-hover #1890

merged 1 commit into from Jul 19, 2017

Conversation

dy
Copy link
Contributor

@dy dy commented Jul 18, 2017

Enable better hover detection

resolves #1889

@etpinard

@etpinard
Copy link
Contributor

etpinard commented Jul 18, 2017

@dfcreative Thanks for fix! 🎉

Can you make a standalone page with this patch so that we can test it on browserstack?

@rreusser
Copy link
Contributor

At risk of interfering, does this work? https://codepen.io/rsreusser/full/qjGvxN/

@dy
Copy link
Contributor Author

dy commented Jul 18, 2017

@rreusser yep.
@etpinard here is the standalone page https://dfcreative.github.io/plotly-contrib/has-hover

@alexcjohnson
Copy link
Contributor

Can someone with an android phone try this out? It fails for me for Chrome on the android devices I tried on browserstack, but works on my wife's google pixel. Everywhere else I've tried it seems to work great.

@etpinard etpinard added this to the 1.29.0 milestone Jul 18, 2017
@etpinard
Copy link
Contributor

hasHover works for me on Android Chrome 59.0.3071.125

@alexcjohnson
Copy link
Contributor

Alright - I'm willing to assume there's something funny going on with browserstack in that regard, since it seems to work on all the devices we can actually get our hands on. Thanks @rreusser and @dfcreative ! 💃

@etpinard
Copy link
Contributor

@dfcreative by the way 💃 means: you're free to merge. We let plotly dev merge their own PRs. That means more commits on master for you 🏁

@dy dy merged commit 97d08c8 into master Jul 19, 2017
@dy dy deleted the bump-has-hover branch July 19, 2017 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modebar always visible in FF and IE
4 participants