Colorbar loops #1906
Merged
Colorbar loops #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nicely done 💃
... which might be related to #970 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes part of #179 - it works now with heatmap (and in fact any SVG type that makes a colorbar, like bubble charts). The chart it makes looks a bit weird (the colorscale should be smooth, and the ticks should be evenly spaced), but I think that's probably a good thing, as it will alert the user that they're at the limit of javascript's precision.
Resulted in a few sub-pixel changes in baselines, I think they're fine but I notice we're not doing crisp rendering of colorbars - particularly the outlines, but line levels should probably be crisp too - so I will make an issue for that look at this again afterward.