Subplot registration #193
Merged
Subplot registration #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,7 +41,7 @@ plots.fontWeight = 'normal'; | |||
| */ | |||
| plots.register = function(_module, thisType, categoriesIn, meta) { | |||
| if(modules[thisType]) { | |||
| console.warn('type ' + thisType + ' already registered'); | |||
| console.log('type ' + thisType + ' already registered'); | |||
There was a problem hiding this comment.
Bringing in @bpostlethwaite and @alexcjohnson
Should we warn (or spit out a console.log) when users register the same plot module twice?
I'd vote for doing nothing at all.
@mdtusz If I'm no mistaken, every time a user registers two or more trace modules that rely on the same plot module e.g.
var PlotlyBar = require('plotly.js/lib/bar');
var PlotlyBox = require('plotly.js/lib/box');
Plotly.register([PlotlyBar, PlotlyBox]);would split out a log.
There was a problem hiding this comment.
Fyi I switched log --> warn out of (perhaps bad) habit, from when I had a project that needed to support ie8 😦
There was a problem hiding this comment.
Oh boy. No way plotly.js works in ie8
|
How are we feeling on this one @etpinard? |
|
💃 let's merge this in. We can revisit the log vs warn issue later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some slight changes so that the
plotmodules will be loaded along with their respective traces.This will allow us to slim down the bundle size even more in the case where only a few traces (e.g. no gl) are needed.