Scale image in Plotly.toImage
#1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- which draw image data on bigger canvas (for png/jpeg/webp) - and scales svg using top-level width/height/viewBox attribute
etpinard
commented
Sep 1, 2017
| @@ -128,7 +140,6 @@ function toImage(gd, opts) { | |||
| // extend config for static plot | |||
| var configImage = Lib.extendFlat({}, config, { | |||
| staticPlot: true, | |||
| plotGlPixelRatio: config.plotGlPixelRatio || 2, | |||
There was a problem hiding this comment.
Ooops. This should have been in a separate commit. In brief, this line was useless, so 🔪
alexcjohnson
reviewed
Sep 1, 2017
src/snapshot/svgtoimg.js
Outdated
| @@ -33,6 +33,12 @@ function svgToImg(opts) { | |||
| } | |||
|
|
|||
| var canvas = opts.canvas; | |||
| var scale = opts.scale || 1; | |||
| var w0 = opts.width || 150; | |||
| var h0 = opts.height || 300; | |||
There was a problem hiding this comment.
Good eyes! Done in 633882b
|
Brilliant. 💃 after #1979 (comment) |
|
Thanks for the quick review @alexcjohnson ! I'll leave this one unmerged until |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
scaleoption toPlotly.toImage(andPlotly.downloadImage) which scales the generated image by a given factor. Note that, scaling an image isn't the same as just relayouting it to some factor times the current layoutwidth/heightvalues. Scaling scales every feature of a graph - this should help users that want higher resolution image exports.The new
scalehas an effect on all the supported formats. Forpng,jpegandwebpthis is accomplished usingcontext.drawImage's width/height options. Forsvg, we tweak theviewBoxattribute similar to during scroll/pan interactions.