Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear axis title on full axis redraw #1981

Merged
merged 1 commit into from
Sep 5, 2017
Merged

Clear axis title on full axis redraw #1981

merged 1 commit into from
Sep 5, 2017

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented Sep 1, 2017

fixes #1914

This should do the trick 馃帺

@alexcjohnson
Copy link
Collaborator

man, axid === 'redraw' makes me cringe but... yeah, all my doing. Looks great, and if we ever clean up that hack the test will make sure we get this right.

馃拑

@etpinard
Copy link
Contributor Author

etpinard commented Sep 5, 2017

man, axid === 'redraw' makes me cringe

Yeah. Axes.doTicks is probably the hackiest function in all of plotly.js at the moment. 馃捇

@etpinard etpinard merged commit b1368f6 into master Sep 5, 2017
@etpinard etpinard deleted the axis-visible-clear-title branch September 5, 2017 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: reviewable type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting y-axis to invisible does not clear its title
2 participants
@etpinard @alexcjohnson