Skip to content

Remove smith attribute #2093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2017
Merged

Remove smith attribute #2093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/plots/layout_attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,14 +168,6 @@ module.exports = {
'forked graphs from the plotly service (at https://plot.ly or on-premise).'
].join(' ')
},
smith: {
// will become a boolean if/when we implement this
valType: 'enumerated',
role: 'info',
values: [false],
dflt: false,
editType: 'none'
},
showlegend: {
// handled in legend.supplyLayoutDefaults
// but included here because it's not in the legend object
Expand Down
1 change: 0 additions & 1 deletion src/plots/plots.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1137,7 +1137,6 @@ plots.supplyLayoutGlobalDefaults = function(layoutIn, layoutOut) {

coerce('separators');
coerce('hidesources');
coerce('smith');

Registry.getComponentMethod(
'calendars',
Expand Down
1 change: 0 additions & 1 deletion test/image/mocks/contour_match_edges.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10487,7 +10487,6 @@
"title":"Click to enter Plot title",
"plot_bgcolor":"#fff",
"dragmode":"zoom",
"smith":false,
"width":964,
"bargap":0.2,
"xaxis":{
Expand Down
1 change: 0 additions & 1 deletion test/image/mocks/gl3d_opacity-surface.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7848,7 +7848,6 @@
"paper_bgcolor": "#fff",
"plot_bgcolor": "#fff",
"dragmode": "zoom",
"smith": false,
"scene": {
"domain": {
"y": [
Expand Down
1 change: 0 additions & 1 deletion test/image/mocks/titles-avoid-labels.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,6 @@
"hovermode": "x",
"separators": ".,",
"hidesources": false,
"smith": false,
"showlegend": false
}
}