Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hoverlabel.zformat #2106

Merged
merged 12 commits into from
Oct 26, 2017
Merged

Hoverlabel.zformat #2106

merged 12 commits into from
Oct 26, 2017

Conversation

jdugge
Copy link
Contributor

@jdugge jdugge commented Oct 19, 2017

Add a zhoverformat option to heatmap and contour traces which specifies the number format to use for displaying z values.

@etpinard
Copy link
Contributor

@jdugge would you mind fixing the conflict in fx/hover.js?

@jdugge
Copy link
Contributor Author

jdugge commented Oct 20, 2017

The conflict is resolved, as is a formatting error that caused lint to complain. The failure of select_test seems to be unrelated to this PR, as other currently open PR's have the same error?

- PR plotly#2099 got merged
  on a branch behind plotly#2081
  which caused the test to fail on master.
@etpinard
Copy link
Contributor

The failure of select_test seems to be unrelated to this PR, as other currently open PR's have the same error?

Thanks for pointing this out. The issue was fixed in #2109

Would you mind merging master once more into your branch?

@etpinard etpinard added this to the v1.32.0 milestone Oct 20, 2017
@jdugge
Copy link
Contributor Author

jdugge commented Oct 20, 2017

Alright, I think that's it 🤞

@etpinard
Copy link
Contributor

Ooh, I forget to merge this thing. Big shoutout to @jdugge for this solid PR!

This will be part of the 1.32.0 release (set for mid-week next-week).

@etpinard etpinard merged commit a4e748f into plotly:master Oct 26, 2017
@jdugge jdugge deleted the hoverlabel.zformat branch October 26, 2017 18:50
@alexcjohnson alexcjohnson mentioned this pull request Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants