Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scattergeo and choropleth click and hover events #215

Merged
merged 4 commits into from Jan 28, 2016
Merged

Conversation

etpinard
Copy link
Contributor

@mdtusz @cpsievert

About time I do this.

@cpsievert
Copy link

💥 🎉

.attr('class', 'trace scattergeo');
.attr('class', 'trace scattergeo');

gScatterGeoTraces.exit().remove();

// TODO add hover - how?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need this anymore 🎉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, we still need this unfortunately. scattergeo trace with mode 'lines' don't have any hover text at the moment.

@mdtusz
Copy link
Contributor

mdtusz commented Jan 28, 2016

Nice work.
💃

etpinard added a commit that referenced this pull request Jan 28, 2016
Scattergeo and choropleth click and hover events
@etpinard etpinard merged commit c58fe87 into master Jan 28, 2016
@etpinard etpinard deleted the geo-events branch January 28, 2016 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants