Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locales: add Spanish translations #2249

Merged
merged 5 commits into from Jan 18, 2018

Conversation

Projects
None yet
4 participants
@n-riesco
Copy link
Collaborator

commented Jan 12, 2018

Provided translations for all the keys.

Translations:

  • Make a PR directly to the main repository
  • Label it type: translation
  • Please @ mention a few other speakers of this language who can help review your translations.
  • If you've omitted any keys from dist/translation_keys.txt - which means they will fall back on the US English text - just make a short comment about why in the PR description: the English text works fine in your language, or you would like someone else to help translating those, or whatever the reason.
  • You should only update files in lib/locales/, not those in dist/
@alexcjohnson

This comment has been minimized.

Copy link
Contributor

commented Jan 15, 2018

Thanks @n-riesco ! Are there any of the translations you're not confident in? Any other Spanish speakers you can ping to review?

Also, I'm reminded by #2246 - does Spanish use different decimal and thousands separators than English?

'Zoom out': 'Reducir', // components/modebar/buttons.js:130
'close:': 'cierre:', // traces/ohlc/transform.js:139
'high:': 'alza:', // traces/ohlc/transform.js:137
'incoming flow count:': 'flujo de entrada', // traces/sankey/plot.js:142

This comment has been minimized.

Copy link
@alexcjohnson

alexcjohnson Jan 15, 2018

Contributor

trailing : (also outgoing)

'q3:': 'q3:', // traces/box/calc.js:131
'source:': 'fuente:', // traces/sankey/plot.js:140
'target:': 'destino:', // traces/sankey/plot.js:141
'trace': 'traza:', // plots/plots.js:305

This comment has been minimized.

Copy link
@alexcjohnson

alexcjohnson Jan 15, 2018

Contributor

this one actually does not get a trailing quote - it's used in default trace names "trace 0" etc.

This comment has been minimized.

Copy link
@alexcjohnson

alexcjohnson Jan 15, 2018

Contributor

(I mean trailing colon)

'Taking snapshot - this may take a few seconds': 'Capturando una instantánea - podría tardar unos segundos', // components/modebar/buttons.js:57
'Toggle Spike Lines': 'Mostrar/Ocultar Guías', // components/modebar/buttons.js:547
'Toggle show closest data on hover': 'Activar/Desactivar mostrar el dato más cercano al pasar por encima', // components/modebar/buttons.js:352
'Turntable rotation': 'Rotación plana', // components/modebar/buttons.js:288

This comment has been minimized.

Copy link
@alexcjohnson

alexcjohnson Jan 15, 2018

Contributor

Oh that's cool - it's like planar vs spherical rotation? That may be a good reference for other translators in the future 🏆

This comment has been minimized.

Copy link
@n-riesco

n-riesco Jan 16, 2018

Author Collaborator

For this translation, I followed Blender.

dictionary: {
'Autoscale': 'Autoescalar', // components/modebar/buttons.js:139
'Box Select': 'Seleccionar Caja', // components/modebar/buttons.js:103
'Click to enter Colorscale title': 'Haga clic para introducir el título de la Escala de Color', // plots/plots.js:303

This comment has been minimized.

Copy link
@alexcjohnson

alexcjohnson Jan 15, 2018

Contributor

hmm, these ones are getting a bit long, worries me about overflow. Do you think it would make sense to users that these are elements you can click and type new values if we leave off "Haga clic para" and just start at "Introducir" (or some conjugation thereof)?

This comment has been minimized.

Copy link
@n-riesco

n-riesco Jan 16, 2018

Author Collaborator

OK, it should be clear enough. In theory, DRAE accepts clicar, but my experience is that clicar isn't so commonly used.

@n-riesco

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 16, 2018

@alexcjohnson

Are there any of the translations you're not confident in?

The case I like the least is incoming flow count: and outgoing flow count:; instead I've used the Spanish translation for incoming flow: and outgoing flow:. Hope this is OK.

Any other Spanish speakers you can ping to review?

I was hoping I wouldn't be the only Spanish speaker here.
I'll look for someone.

Also, I'm reminded by #2246 - does Spanish use different decimal and thousands separators than English?

Oh, yes, the official decimal marker in Spain is the comma (in fact, that's case for Latin America and continental Europe).

But, in scientific contexts, the dot is also used (as recommended by BIPM).

I'll set the decimal marker to comma (as this is what libreoffice and other programs do).

@etpinard etpinard added this to the v1.33.0 milestone Jan 16, 2018

@n-riesco

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 17, 2018

@alexcjohnson I've got someone (who isn't on github, but I've asked him to open an account) to review the translations and I have a few corrections to make (I'll make them tomorrow at the latest).

@i-mozo

This comment has been minimized.

Copy link

commented Jan 17, 2018

The native Spanish speaker here. I have reviewed the translation and sent some comments about it.
Good job. Keep it up!

@alexcjohnson

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2018

Thanks for your help @i-mozo 🎁

@n-riesco

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 18, 2018

@alexcjohnson I've just made Ismael's corrections. The PR is ready.

@alexcjohnson alexcjohnson merged commit 98747b0 into plotly:master Jan 18, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.