New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mute event listener logging #2251

Merged
merged 3 commits into from Jan 18, 2018

Conversation

Projects
None yet
3 participants
@dy
Member

dy commented Jan 15, 2018

Fixes #1795

@alexcjohnson

This comment has been minimized.

Show comment
Hide comment
@alexcjohnson

alexcjohnson Jan 15, 2018

Contributor

Ah, I see - so basically this is just attaching the event in a different way that allows us to tell the browser "yes, we know this isn't passive, stop bugging us"?

I like the _onwheel etc solution. LGTM! 💃

Contributor

alexcjohnson commented Jan 15, 2018

Ah, I see - so basically this is just attaching the event in a different way that allows us to tell the browser "yes, we know this isn't passive, stop bugging us"?

I like the _onwheel etc solution. LGTM! 💃

@dy

This comment has been minimized.

Show comment
Hide comment
@dy

dy Jan 17, 2018

Member

@etpinard resolved

Member

dy commented Jan 17, 2018

@etpinard resolved

@etpinard

This comment has been minimized.

Show comment
Hide comment
@etpinard

etpinard Jan 18, 2018

Member

Nicely done. Merge away (when you get the chance) 💃

Member

etpinard commented Jan 18, 2018

Nicely done. Merge away (when you get the chance) 💃

@etpinard

This comment has been minimized.

Show comment
Hide comment
@etpinard

etpinard Jan 18, 2018

Member

Dima must be travelling today. Merging this thing so that it's part of 1.33.0.

Member

etpinard commented Jan 18, 2018

Dima must be travelling today. Merging this thing so that it's part of 1.33.0.

@etpinard etpinard merged commit 41fc131 into master Jan 18, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@etpinard etpinard deleted the passive-event-logging branch Jan 18, 2018

@dy dy referenced this pull request Jan 25, 2018

Merged

Panning in mobile devices #2296

3 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment