Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ghost fill-tonext when either trace is emptied out #2280

Merged
merged 1 commit into from Jan 23, 2018

Conversation

Projects
None yet
2 participants
@alexcjohnson
Copy link
Contributor

commented Jan 23, 2018

Fixes #2271 - we were short-circuiting a little too much behavior when no line is generated by a trace.

@dfcreative another quick one to look at, if you would!

@dy

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2018

Turns out this test case does not work with scattergl, although it should, I should have a look.
Also is that correct that the legend shows an empty trace?
image
In all looks good!

@alexcjohnson

This comment has been minimized.

Copy link
Contributor Author

commented Jan 23, 2018

is that correct that the legend shows an empty trace?

Yes, trace 1 has mode: 'lines', line: {width: 0}, rendering it invisible (could have just done mode: 'none' like trace 2 but without the fill, but this works too)

@dy

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2018

💃 :)

@alexcjohnson alexcjohnson merged commit 536ba6f into master Jan 23, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@alexcjohnson alexcjohnson deleted the ghost-fill branch Jan 23, 2018

@dy dy referenced this pull request Jan 23, 2018

Open

Scattergl tonext case #2284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.