Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stacking of centered hover info elements #865 #2445

Merged
merged 1 commit into from Mar 6, 2018

Conversation

Projects
None yet
2 participants
@rmoestl
Copy link
Contributor

rmoestl commented Mar 6, 2018

This fixes #865: boxes of multiple centered hover info elements had all the same vertical position, hence hiding each other and not "following" associated text labels in terms of positioning.

Final solution:
865_stacked_centered_hover_info_elements

Fix stacking of centered hover info elements #865
- Bug: boxes of multiple centered hover info elements had
  all the same vertical position, hence hiding each other,
  not "following" associated text labels in terms of
  positioning.

@rmoestl rmoestl added the type: bug label Mar 6, 2018

@rmoestl rmoestl self-assigned this Mar 6, 2018

@rmoestl rmoestl requested review from alexcjohnson and etpinard Mar 6, 2018

@alexcjohnson
Copy link
Contributor

alexcjohnson left a comment

Beautiful. Always annoying when a one-line fix takes 100 lines to test, but that's how it goes. 💃

@rmoestl rmoestl merged commit 161b602 into master Mar 6, 2018

5 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test-image Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine2 Your tests passed on CircleCI!
Details
ci/circleci: test-syntax Your tests passed on CircleCI!
Details

@etpinard etpinard deleted the fix-centered-hover-info-elems-stacked branch Mar 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.