Handle HTML links with encoded URIs correctly in svg text labels #2239 #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bug: an already escaped URI of an HTML link was encoded a second time by Plotly which led to a wrong URI.
alexcjohnson
approved these changes
Mar 13, 2018
There was a problem hiding this comment.
Looks great, thanks! 💃
There's one unrelated failing test, must be an intermittent failure. I feel like I've seen that one fail before, so perhaps we can mark it @flaky? Those tests still run on CI, but they get picked up in a separate process that retries a few times before failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2239.
Bug description: an already escaped URI of an HTML link was encoded a second time by Plotly which led to a wrong URI.