Make ordered category algo skip over visible false traces #2489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc'ing back-from-vacation @alexcjohnson |
|
Hmm, trying to figure out why this works I stumbled on another problem with ordered categories, the categories cease to be subplot-specific (though we do differentiate x/y): Plotly.newPlot(gd, [
{x: ['a', 'c', 'e', 'g']},
{x: ['b', 'd', 'f', 'h'], xaxis: 'x2'}
], {
xaxis: {categoryorder: 'category ascending', domain: [0, 0.4]},
xaxis2: {categoryorder: 'category ascending', domain: [0.6, 1]},
width: 700, height: 400
})
|
- 🔪 'pure' ordered_categories.js and move logic to category_order_defaults (no need for two files for this stuff here) - replace d3.bisector-based search-and-replace algo by lookup object, which bring number categories on par with their string rep (e.g. 1 same as '1' - see issue #1460) - use native array sort() to order categories instead of d3 version
|
Beautiful - squishes 2 bugs plus the new one reported here! 💃 💃 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2488