New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not collapse duplicate end points when `line.simplify: false` #2814

Merged
merged 1 commit into from Jul 16, 2018

Conversation

Projects
None yet
2 participants
@etpinard
Member

etpinard commented Jul 13, 2018

resolves #2794 by allowing smooth transitions of lines with the same number of coordinates:

peek 2018-07-13 10-06

cc @alexcjohnson

do not collaspe duplicate end points when line.simplify:false
... so that such lines can transition smoothly
@etpinard

This comment has been minimized.

Show comment
Hide comment
@etpinard
Member

etpinard commented Jul 13, 2018

@alexcjohnson

This comment has been minimized.

Show comment
Hide comment
@alexcjohnson

alexcjohnson Jul 14, 2018

Contributor

It's a good sign when you can fix a bug in negative LOC :) 💃

Contributor

alexcjohnson commented Jul 14, 2018

It's a good sign when you can fix a bug in negative LOC :) 💃

@etpinard etpinard merged commit cd75f69 into master Jul 16, 2018

6 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test-image Your tests passed on CircleCI!
Details
ci/circleci: test-image2 Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine2 Your tests passed on CircleCI!
Details
ci/circleci: test-syntax Your tests passed on CircleCI!
Details

@etpinard etpinard deleted the simplify-no-duplicate-pts branch Jul 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment