New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix legend item for 'legendonly' traces with array 'marker.symbol' #2816

Merged
merged 3 commits into from Jul 16, 2018

Conversation

Projects
None yet
2 participants
@etpinard
Member

etpinard commented Jul 13, 2018

fixes #2672

Ending the week with -- guess what -- another bug fix cc @alexcjohnson

"yaxis": "y2",
"marker": {
"size": 15,
"symbol": ["square", "square", "square", "square", "square", "square", "square", "square", "square"]

This comment has been minimized.

@etpinard

etpinard Jul 13, 2018

Member

The legend item here currently renders as a circle (using the Drawing.singlePointStyle fallback).

@etpinard

etpinard Jul 13, 2018

Member

The legend item here currently renders as a circle (using the Drawing.singlePointStyle fallback).

@alexcjohnson

This comment has been minimized.

Show comment
Hide comment
@alexcjohnson

alexcjohnson Jul 14, 2018

Contributor

💃 Capping off a pretty great week!

Contributor

alexcjohnson commented Jul 14, 2018

💃 Capping off a pretty great week!

@etpinard etpinard merged commit f9e90c4 into master Jul 16, 2018

6 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test-image Your tests passed on CircleCI!
Details
ci/circleci: test-image2 Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine2 Your tests passed on CircleCI!
Details
ci/circleci: test-syntax Your tests passed on CircleCI!
Details

@etpinard etpinard deleted the legendonly-arrayok-marker-symbol branch Jul 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment