New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scattergeo selection fixups #2827

Merged
merged 2 commits into from Jul 23, 2018

Conversation

Projects
None yet
2 participants
@etpinard
Member

etpinard commented Jul 19, 2018

fixes a few issues with scattergeo selection:

  • [un]selected.marker.opacity never got coerced correctly, and no one has reported this before @rmoestl did a few hours ago 馃槕
  • some geo projections return [NaN, NaN] when trying to convert bad lon/lat coordinates into pixels, but some others (e.g. robinson -> https://rreusser.github.io/plotly-mock-viewer/#geo_country-names) throw up on bad lon/lat. From now on, we won't take any chances.

@alexcjohnson

@alexcjohnson

This comment has been minimized.

Show comment
Hide comment
@alexcjohnson

alexcjohnson Jul 21, 2018

Contributor

Very nice, 馃拑 Thanks for the report @rmoestl!

Contributor

alexcjohnson commented Jul 21, 2018

Very nice, 馃拑 Thanks for the report @rmoestl!

@etpinard etpinard merged commit e1ecd18 into master Jul 23, 2018

6 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test-image Your tests passed on CircleCI!
Details
ci/circleci: test-image2 Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine2 Your tests passed on CircleCI!
Details
ci/circleci: test-syntax Your tests passed on CircleCI!
Details

@etpinard etpinard deleted the scattergeo-select-fixups branch Jul 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment