Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overlaying subplot configuration relayouts #2831

Merged
merged 6 commits into from Jul 23, 2018

Conversation

Projects
None yet
2 participants
@etpinard
Copy link
Member

commented Jul 20, 2018

fixes #2828 and moves a few "clean up old layer" blocks out of Plots.supplyDefaults and into Cartesian.drawFramework (cc #2549).

cc @alexcjohnson @nicolaskruchten

etpinard added some commits Jul 20, 2018

rm old hack that got selection gl2d subplots working
- this was only used for scattergl and now scattergl
  is plotted on 'cartesian' subplots.
include info about things that reset subplot layers in d3-data
- to clean what need to be cleaned up in exit selection,
  instead of using granular and brittle old vs new plotinfo logic
- axis.layer, overlays are currently include, we might want to
  include more things in it eventually,
adapt selectAll('g.subplot').each(d) data structure
- now 'd' is an array, and the subplot id is in d[0].
rm now obsolete 'clean axis layer' code in Plots.linkSubplots
- this should never have been part of Plots.supplyDefaults pipeline.
@alexcjohnson

This comment has been minimized.

Copy link
Contributor

commented on src/plots/plots.js in efc9faf Jul 21, 2018

🎉 there’s probably a lesson here, if we need selectAll('*') we’re doing things wrong 😏

@alexcjohnson

This comment has been minimized.

Copy link
Contributor

commented Jul 21, 2018

Lovely. Nice bug fix and a structural step in the right direction to boot! 💃

@etpinard etpinard merged commit dcaebc2 into master Jul 23, 2018

6 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test-image Your tests passed on CircleCI!
Details
ci/circleci: test-image2 Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine2 Your tests passed on CircleCI!
Details
ci/circleci: test-syntax Your tests passed on CircleCI!
Details

@etpinard etpinard deleted the subplot-overlaying-toggle-relayouts branch Jul 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.