fallback to max-width and max-height if necessary #3033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
reviewed
Sep 21, 2018
antoinerg
commented
Sep 24, 2018
There was a problem hiding this comment.
It looks like computedStyle.height will never be greater than computedStyle.maxHeight because it's the computed style ie. css logic was applied.
The problem we're solving here is the rare case where a CSS developer didn't specify the height of the container. In that case, newHeight is 0 and the final height ends up with the default value of 450 which is sometimes too large and overflows the div.
Thanks for the info! Let's 💃 |
|
Closes #2968 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix to issue #2968