Do not to look for 'add' or 'remove' when replacing array containers #3053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this didn't lead to any bugs, as the correct editType was resolved, it lead to false Lib.warn message.
|
Everyone's favorite super-hacky API syntax 😅 thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes an issue brought up in https://community.plot.ly/t/posible-issue-in-plotly-relayout-and-passing-in-an-update-object-with-a-shapes-array/13975 - which didn't lead to any bugs (as the correct
editTypewas still resolved), but lead to a falseLib.warnmessage in the console.This PR is essentially a small fixup of commit 138a84f#diff-2941ab69a12080c0633ff4ac8ea3aa83 from PR #2823 (fast axis autorange).
@alexcjohnson @antoinerg @archmoj