Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
responsive figures in CSS flexbox and grid #3056
Modern CSS layouts are able to grow and shrink children according to the leftover space. The leftover space is the space to fill minus the base sizes of the non-flexible grid tracks. Because the svg-container gets a fixed
Looks great @antoinerg! The new and updated tests are very good, but I think it's still a good idea to test this manually in streambed before we merge - check that the 3 key plot environments we have there work as they do now: create, shareplot, and embedplot.
Here are some (maybe outdated) docs about on how to that:
Oct 5, 2018
6 checks passed
@etpinard The issue right now with the plotly-mock-viewer is due to the fact that it uses a container with
To make it work as it used to, I will change the following line
to something like
similarly to what I've done for the height:
This should fix the issue. I will write a test to make sure that it does and that we get correct results for the various CSS display options.
@alexcjohnson suggested I open a new PR so I will do that tomorrow!