Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implied edits connecting height/width/autosize #3120

Merged
merged 2 commits into from Oct 17, 2018

Conversation

Projects
None yet
2 participants
@alexcjohnson
Copy link
Contributor

commented Oct 17, 2018

So you can turn autosize back on again, using relayout or update, after it's been turned off and replaced by explicit height & width.

@antoinerg please review. Shouldn't have any adverse impact on the autosize work you did recently as this only affects edit behavior (and only the older modes, not react)

// can't use impliedEdits for this because behavior depends on vi
if(['width', 'height'].indexOf(ai) !== -1) {
if(vi) {
doextra('autosize', null);

This comment has been minimized.

Copy link
@alexcjohnson

alexcjohnson Oct 17, 2018

Author Contributor

FYI doextra(attr, null) works (with some caveats) just like relayout(gd, attr, null) in that it deletes that attribute from layout

@alexcjohnson

This comment has been minimized.

Copy link
Contributor Author

commented Oct 17, 2018

Oh hmm, @antoinerg turns out I did impact at least your autosize tests - need to look at whether those failures make sense.

@antoinerg

This comment has been minimized.

Copy link
Collaborator

commented Oct 17, 2018

I don't think it interferes with any of my work on responsive and autosize. The tests that are failing are from before my time. I will need to take a closer look 👀

@antoinerg

This comment has been minimized.

Copy link
Collaborator

commented Oct 17, 2018

Looks good to me! You can merge it in 💃

@alexcjohnson alexcjohnson merged commit 435a656 into master Oct 17, 2018

6 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test-image Your tests passed on CircleCI!
Details
ci/circleci: test-image2 Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine2 Your tests passed on CircleCI!
Details
ci/circleci: test-syntax Your tests passed on CircleCI!
Details

@alexcjohnson alexcjohnson deleted the autosize-edits branch Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.