Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rangeslider on reversed axes #3304

Merged
merged 3 commits into from Dec 12, 2018

Conversation

Projects
None yet
2 participants
@etpinard
Copy link
Member

etpinard commented Dec 3, 2018

fixes #3075

cc @plotly/plotly_js

@alexcjohnson

This comment has been minimized.

Copy link
Contributor

alexcjohnson commented Dec 4, 2018

Very nice fix! But what's up with the fuzzy line in the test image (between 10&9, 8&7, 3&2)?
screen shot 2018-12-04 at 4 42 40 pm

@etpinard

This comment has been minimized.

Copy link
Member Author

etpinard commented Dec 4, 2018

But what's up with the fuzzy line in the test image (between 10&9, 8&7, 3&2)?

Looks like it's a weird nw.js artifact. Here's how it looks like using orca:

image

rm shape:'spline' from range slider reversed range mock
... which rendered oddly in our nw.js imagetest container.
@etpinard

This comment has been minimized.

Copy link
Member Author

etpinard commented Dec 12, 2018

But what's up with the fuzzy line in the test image (between 10&9, 8&7, 3&2)?

Those fuzzy lines go away when removing shape: 'spline' from the mock.

@alexcjohnson

This comment has been minimized.

Copy link
Contributor

alexcjohnson commented Dec 12, 2018

💃

@etpinard etpinard merged commit 9ee3f45 into master Dec 12, 2018

8 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: publish Your tests passed on CircleCI!
Details
ci/circleci: test-image Your tests passed on CircleCI!
Details
ci/circleci: test-image2 Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine2 Your tests passed on CircleCI!
Details
ci/circleci: test-syntax Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details

@etpinard etpinard deleted the rangeslider-on-reversed-axes branch Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.