Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "Edit in Chart Studio" button by default #3307

Merged
merged 1 commit into from Dec 6, 2018

Conversation

Projects
None yet
3 participants
@alexcjohnson
Copy link
Contributor

commented Dec 5, 2018

Closes #316 - removes the "Edit in Chart Studio" button by default, and adds a new config arg showSendToCloud to re-enable it.

cc @etpinard @nicolaskruchten @chriddyp any comments in particular on the name of this new arg?

remove "Edit in Chart Studio" button by default
and add config arg `showSendToCloud` to re-enable it
@nicolaskruchten

This comment has been minimized.

Copy link
Member

commented Dec 5, 2018

Works for me.

@etpinard

This comment has been minimized.

Copy link
Member

commented Dec 5, 2018

💃

@nicolaskruchten

This comment has been minimized.

Copy link
Member

commented Dec 5, 2018

We’ll definitely need to adjust stuff in streambed when bumping the dep there

@alexcjohnson alexcjohnson merged commit 5a9e340 into master Dec 6, 2018

8 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: publish Your tests passed on CircleCI!
Details
ci/circleci: test-image Your tests passed on CircleCI!
Details
ci/circleci: test-image2 Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine2 Your tests passed on CircleCI!
Details
ci/circleci: test-syntax Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details

@alexcjohnson alexcjohnson deleted the dflt-no-cloud branch Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.