Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make corrections to Finnish locale translations #3325

Merged
merged 2 commits into from
Dec 13, 2018
Merged

Make corrections to Finnish locale translations #3325

merged 2 commits into from
Dec 13, 2018

Conversation

lmalmber
Copy link
Contributor

Months and days of the week are written lowercase in Finnish. The list of short days also included a duplicate Sunday in place of Saturday.

Another library I use in the same project with Plotly.js does this correctly, which is why I noticed this:
https://github.com/charliekassel/vuejs-datepicker/blob/master/src/locale/translations/fi.js

Sources:

  • Institute for the Languages of Finland: Months, Days
  • I am a native speaker of Finnish

Months and days of the week are written lowercase in Finnish. The list
of short days also included a duplicate Sunday in place of Saturday.
@etpinard
Copy link
Contributor

Thanks! Would you be interested in filling up the dictionary translating expression from https://github.com/plotly/plotly.js/blob/master/dist/translation-keys.txt ?

@lmalmber
Copy link
Contributor Author

Hey, I added the dictionary translations. I don't currently know any other Finnish person I could refer to double check them, but I'm fairly satisfied with the translations.

@etpinard etpinard added this to the v1.43.0 milestone Dec 13, 2018
@etpinard
Copy link
Contributor

Thanks very much! This will be part of 1.43.0.

@etpinard etpinard merged commit 92c2887 into plotly:master Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants