Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metatext #3439

Merged
merged 6 commits into from
Jan 16, 2019
Merged

Metatext #3439

merged 6 commits into from
Jan 16, 2019

Conversation

etpinard
Copy link
Contributor

resolves #3427

cc @plotly/plotly_js and @nicolaskruchten

@alexcjohnson
Copy link
Collaborator

Does it need to be text? Should we just call it layout.meta? I'm imagining in the short term templating numbers (potentially with a format spec), and longer term possibly using this as a way to share other settings across multiple traces, axes, etc.

@etpinard
Copy link
Contributor Author

Should we just call it layout.meta

I don't have a strong opinion.

@nicolaskruchten
Copy link
Member

Looks great to me! meta works for me, although there is no requirement today to support anything beyond text, we may as well leave the door open.

@etpinard
Copy link
Contributor Author

Looks great to me! meta works for me

done in b03e777

@nicolaskruchten
Copy link
Member

💃

@nicolaskruchten
Copy link
Member

Ah hang on, do we need to add anything for metasrc ?

@nicolaskruchten
Copy link
Member

Just so the plotly.py machinery etc doesn't complain about Chart Studio sliding that in...

@etpinard
Copy link
Contributor Author

do we need to add anything for metasrc

That's done automatically here:

if(attr.valType === 'data_array') {
// all 'data_array' attrs have role 'data'
attr.role = 'data';
// all 'data_array' attrs have a corresponding 'src' attr
attrs[attrName + 'src'] = makeSrcAttr(attrName);
}

@nicolaskruchten
Copy link
Member

ok great :)

@etpinard etpinard merged commit c44ed53 into master Jan 16, 2019
@etpinard etpinard deleted the metatext branch January 16, 2019 17:25
@etpinard etpinard mentioned this pull request May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

layout.metatext
3 participants